Skip to content

Better handling of faulty unloading of appa #3199

Better handling of faulty unloading of appa

Better handling of faulty unloading of appa #3199

Triggered via pull request October 26, 2023 16:18
Status Success
Total duration 3m 50s
Artifacts

ci_build.yml

on: pull_request
🔨 Build sources (CI)
3m 37s
🔨 Build sources (CI)
Fit to window
Zoom out
Zoom in

Annotations

1 error and 11 warnings
🔨 Build sources (CI)
; expected
🔨 Build sources (CI)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-dotnet@v1, codecov/codecov-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Common/Exceptions/HomeAssistantApiCallException.cs#L6
Change the base type of NetDaemon.Client.Internal.Exceptions.HomeAssistantApiCallException so that it no longer extends System.ApplicationException. This base exception type does not provide any additional value for framework classes. Extend 'System.Exception' or an existing unsealed exception type instead. Do not create a new exception base type unless there is specific value in enabling the creation of a catch handler for an entire class of exceptions. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1058) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/Net/WebSocketClientImpl.cs#L62
Member 'ReceiveAsync' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/HomeAssistantConnection.cs#L51
Do not create tasks without passing a TaskScheduler (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2008) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/HomeAssistantConnection.cs#L131
'Task<TResult>.Result' synchronously blocks. Use await instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1849) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/HomeAssistantConnection.cs#L132
'Task<TResult>.Result' synchronously blocks. Use await instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1849) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/HomeAssistantConnection.cs#L136
'Task<TResult>.Result' synchronously blocks. Use await instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1849) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/Net/WebSocketTransportPipeline.cs#L14
'WebSocketClientTransportPipeline' contains field '_internalCancelSource' that is of IDisposable type 'CancellationTokenSource', but it is never disposed. Change the Dispose method on 'WebSocketClientTransportPipeline' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/Helpers/ResultMessageHandler.cs#L8
'ResultMessageHandler' contains field '_tokenSource' that is of IDisposable type 'CancellationTokenSource', but it is never disposed. Change the Dispose method on 'ResultMessageHandler' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/HomeAssistantConnection.cs#L13
'HomeAssistantConnection' contains field '_hassMessageSubject' that is of IDisposable type 'Subject<HassMessage>', but it is never disposed. Change the Dispose method on 'HomeAssistantConnection' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]
🔨 Build sources (CI): src/Client/NetDaemon.HassClient/Internal/HomeAssistantConnection.cs#L18
'HomeAssistantConnection' contains field '_messageIdSemaphore' that is of IDisposable type 'SemaphoreSlim', but it is never disposed. Change the Dispose method on 'HomeAssistantConnection' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213) [/home/runner/work/netdaemon/netdaemon/src/Client/NetDaemon.HassClient/NetDaemon.Client.csproj]