Docker login should not happen in PR's

net-daemon · Jan 12, 2021 · acc2b10 · acc2b10
1 parent b747bcc
commit acc2b10
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/push_docker_dev.yml b/.github/workflows/push_docker_dev.yml
@@ -25,8 +25,10 @@ jobs:
       -
         name: 🧰 Available platforms
         run: echo ${{ steps.buildx.outputs.platforms }}
+
       - name: 🔓 Login to docker hub
         run: docker login -u ${{ secrets.DOCKER_USERNAME }} -p ${{ secrets.DOCKER_TOKEN }}
+
       - name: 🛠️ Run Buildx
         run: |
           docker buildx build \

diff --git a/.github/workflows/test_docker.yml b/.github/workflows/test_docker.yml
@@ -23,8 +23,7 @@ jobs:
       -
         name: 🧰 Available platforms
         run: echo ${{ steps.buildx.outputs.platforms }}
-      - name: 🔓 Login to docker hub
-        run: docker login -u ${{ secrets.DOCKER_USERNAME }} -p ${{ secrets.DOCKER_TOKEN }}
+
       - name: 🛠️ Run Buildx
         run: |
           docker buildx build \