Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alfa version of Registry object, work in progress #1077

Merged
merged 11 commits into from
Apr 28, 2024

Conversation

FrankBakkerNl
Copy link
Contributor

@FrankBakkerNl FrankBakkerNl commented Apr 6, 2024

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job with this PR. Just a few comments.

@FrankBakkerNl FrankBakkerNl marked this pull request as ready for review April 27, 2024 14:02
@FrankBakkerNl FrankBakkerNl changed the title Draft of Registry object, work in progress Alfa version of Registry object, work in progress Apr 27, 2024
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 84.76190% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 77%. Comparing base (6bc62b3) to head (45b0c11).

Files Patch % Lines
...odel/NetDeamon.HassModel/Internal/RegistryCache.cs 79% 8 Missing and 9 partials ⚠️
...l/NetDeamon.HassModel/Internal/HassObjectMapper.cs 83% 0 Missing and 6 partials ⚠️
src/HassModel/NetDeamon.HassModel/HaRegistry.cs 68% 0 Missing and 5 partials ⚠️
...n.HassModel/Internal/AppScopedHaContextProvider.cs 83% 2 Missing ⚠️
....HassClient/Common/HomeAssistant/Model/HassArea.cs 75% 1 Missing ⚠️
...c/HassModel/NetDeamon.HassModel/Entities/Entity.cs 80% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##           main   #1077    +/-   ##
=====================================
  Coverage    76%     77%            
=====================================
  Files       181     186     +5     
  Lines      5031    5157   +126     
  Branches    668     660     -8     
=====================================
+ Hits       3870    3982   +112     
  Misses     1027    1027            
- Partials    134     148    +14     
Flag Coverage Δ
unittests 77% <84%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/debug/DebugHost/apps/HelloApp/HelloApp.cs Outdated Show resolved Hide resolved
src/debug/DebugHost/apps/HelloApp/HelloApp.cs Outdated Show resolved Hide resolved
src/debug/DebugHost/apps_src/hellow.cs Outdated Show resolved Hide resolved
Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work !!

@helto4real helto4real merged commit 917adf5 into net-daemon:main Apr 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants