-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alfa version of Registry object, work in progress #1077
Alfa version of Registry object, work in progress #1077
Conversation
ee697ef
to
73156aa
Compare
73156aa
to
7e7c5ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job with this PR. Just a few comments.
src/HassModel/NetDaemon.HassModel.Tests/Registry/RegistryNavigationTest.cs
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
=====================================
Coverage 76% 77%
=====================================
Files 181 186 +5
Lines 5031 5157 +126
Branches 668 660 -8
=====================================
+ Hits 3870 3982 +112
Misses 1027 1027
- Partials 134 148 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work !!
Breaking change
Proposed change
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: