Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for floors and labels to the ServiceTarget class #1084

Merged
merged 4 commits into from
Apr 28, 2024

Conversation

helto4real
Copy link
Collaborator

@helto4real helto4real commented Apr 28, 2024

Breaking change

Proposed change

Add support for floors and labels to the ServiceTarget class
Todo:

  • Add tests

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Contributor

@FrankBakkerNl FrankBakkerNl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just remove all the [Focus] from the debug project and add just while testing something

@helto4real helto4real marked this pull request as ready for review April 28, 2024 18:45
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77%. Comparing base (917adf5) to head (d56d497).

Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1084   +/-   ##
====================================
  Coverage    77%     77%           
====================================
  Files       186     186           
  Lines      5157    5165    +8     
  Branches    660     660           
====================================
+ Hits       3982    3990    +8     
  Misses     1027    1027           
  Partials    148     148           
Flag Coverage Δ
unittests 77% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@helto4real helto4real merged commit f3c00df into main Apr 28, 2024
7 checks passed
@helto4real helto4real deleted the service-target-update branch April 28, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants