Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env for development - part 1 #147

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Env for development - part 1 #147

merged 1 commit into from
Jun 29, 2020

Conversation

helto4real
Copy link
Collaborator

Breaking change

Proposed change

This adds the environmentvariables for NetDaemon Home Assistant to the devcontainer. These will be used in future PR:s fixing the configuration story
Environment vars is better to use so we do not have tokens in files for added security. Also config can be reused over several containers

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real merged commit 090c920 into dev Jun 29, 2020
@helto4real helto4real deleted the fix_dev_container branch June 29, 2020 08:56
@helto4real helto4real restored the fix_dev_container branch June 29, 2020 09:06
@helto4real helto4real deleted the fix_dev_container branch July 1, 2020 11:24
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant