Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start of IOC. Inject YamlConfig. #197

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Start of IOC. Inject YamlConfig. #197

merged 1 commit into from
Aug 22, 2020

Conversation

asherw
Copy link
Contributor

@asherw asherw commented Aug 21, 2020

Breaking change

No breaking change.

Proposed change

On the path to IOCing all the things.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality check)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

helto4real
helto4real approved these changes Aug 22, 2020
View reviewed changes
Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Thanks

@helto4real helto4real merged commit b782135 into dev Aug 22, 2020
@helto4real helto4real deleted the feature/InjectYamlConfig branch August 22, 2020 07:49
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
@asherw
Start of IOC. Inject YamlConfig. (net-daemon#197)
d81aec9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helto4real helto4real helto4real approved these changes

@BeeHiveJava BeeHiveJava Awaiting requested review from BeeHiveJava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asherw @helto4real