Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to .NET 5.0 #228

Merged
merged 10 commits into from
Dec 6, 2020
Merged

Move to .NET 5.0 #228

merged 10 commits into from
Dec 6, 2020

Conversation

helto4real
Copy link
Collaborator

Breaking change

There can be breaking changes due to the move to .NET 5. Please advice!

Proposed change

  • New target .NET 5
  • Fix all nullable warnings
    Coming PR:s
  • Move to records and make stuff immutable
  • Refactor to c# 9

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real merged commit a7f8bf2 into dev Dec 6, 2020
@helto4real helto4real deleted the dotnet5 branch December 6, 2020 12:43
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
* .net fixes

* Move to  .net 5

* Update dep HssClient

* CI: fix the targed sdk version

* CI: fix target sdk version 2

* Fix test

* Fix test 2

* Bump default test timeout

* Temporary disable arm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant