Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fakes: Small fixes #247

Merged
merged 7 commits into from
Dec 13, 2020
Merged

Fakes: Small fixes #247

merged 7 commits into from
Dec 13, 2020

Conversation

helto4real
Copy link
Collaborator

@helto4real helto4real commented Dec 13, 2020 •
edited
Loading

Proposed change

Some small fixes to Fake

  • Make constructor public
  • Some refactors of naming
  • Refactor ND tests using fakes lib too

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real merged commit d8c9bb4 into dev Dec 13, 2020
@helto4real helto4real deleted the test_mocks_fixes branch December 13, 2020 21:24
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
@helto4real
Fakes - refactor tests, naming to make tests easier to write (net-dae…
8877a12 
…mon#247)

* public constructor

* Big refactor of tests

* Add advanced state change tests

* Fix test

* Added more time for slow machines

* Changed naming

* Fix order of events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@helto4real