Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintainence: Roslynator power #265

Merged
merged 11 commits into from
Dec 27, 2020
Merged

Maintainence: Roslynator power #265

merged 11 commits into from
Dec 27, 2020

Conversation

helto4real
Copy link
Collaborator

@helto4real helto4real commented Dec 26, 2020 •
edited
Loading

Breaking change

Proposed change

One of more code refactorings for better maintainablility.

This PR goes wild and fixes strict checks for Roslynator and .Net 5 analyzers. It is hard work but will be worth getting a codebase with same level of code quality.

After this PR I will start refactor some designs but keep backwards compability to the API:s

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real merged commit 1cd6da1 into dev Dec 27, 2020
@helto4real helto4real deleted the roslynator_power branch December 27, 2020 19:08
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
@helto4real
Maintainence: Roslynator power (net-daemon#265)
3fd4a24 
Big refactor of 
- Roslynator linting is default
- .Net 5 linter on
No warnings or messages <3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@helto4real