Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added environment protection for sonar analysis #378

Merged
merged 1 commit into from May 22, 2021

Conversation

helto4real
Copy link
Collaborator

Breaking change

Proposed change

Added environment to protect sonar data

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real added the enhancement New feature or request label May 22, 2021
@helto4real helto4real temporarily deployed to CI - analyze environment May 22, 2021 15:21 Inactive
@helto4real helto4real added pr: enhancement and removed enhancement New feature or request labels May 22, 2021
@helto4real helto4real changed the title Added environment protection Added environment protection for sonar analysis May 22, 2021
@sonarcloud
Copy link

sonarcloud bot commented May 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@BeeHiveJava BeeHiveJava merged commit 2343bea into dev May 22, 2021
@BeeHiveJava BeeHiveJava deleted the environment_sonar_ci branch May 22, 2021 15:28
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants