Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Cleanup and move analysis on own step when pushing to dev and main #401

Merged
merged 4 commits into from
Jul 5, 2021

Conversation

helto4real
Copy link
Collaborator

@helto4real helto4real commented Jul 5, 2021

Breaking change

Proposed change

Remove analysis from PR and use warn as error in build script as quality bar.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real changed the title cleanup CI: Cleanup and move analysis on own step when pushing to dev and main Jul 5, 2021
@helto4real helto4real added enhancement New feature or request pr: enhancement and removed enhancement New feature or request labels Jul 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2021

Codecov Report

❗ No coverage uploaded for pull request base (dev@6b42d11). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev     #401   +/-   ##
======================================
  Coverage       ?   54.80%           
======================================
  Files          ?       83           
  Lines          ?     4585           
  Branches       ?      707           
======================================
  Hits           ?     2513           
  Misses         ?     1846           
  Partials       ?      226           
Flag Coverage Δ
unittests 54.80% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b42d11...e4bfa4b. Read the comment docs.

.github/workflows/ci_analyze.yml Outdated Show resolved Hide resolved
.github/workflows/ci_analyze.yml Outdated Show resolved Hide resolved
.github/workflows/ci_analyze.yml Outdated Show resolved Hide resolved
.github/workflows/ci_analyze.yml Outdated Show resolved Hide resolved
.github/workflows/ci_analyze.yml Outdated Show resolved Hide resolved
.github/workflows/ci_analyze.yml Outdated Show resolved Hide resolved
@helto4real helto4real merged commit ff4f3cc into dev Jul 5, 2021
@helto4real helto4real deleted the cleanup branch July 5, 2021 20:35
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants