-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft NumericSensors #539
Draft NumericSensors #539
Conversation
13c93d8
to
3ae4ef7
Compare
Codecov Report
@@ Coverage Diff @@
## dev #539 +/- ##
==========================================
+ Coverage 59.69% 59.73% +0.03%
==========================================
Files 139 139
Lines 5856 5869 +13
Branches 843 846 +3
==========================================
+ Hits 3496 3506 +10
Misses 2076 2076
- Partials 284 287 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
src/HassModel/NetDaemon.HassModel.CodeGenerator/Generator.Entitites.cs
Outdated
Show resolved
Hide resolved
I think it looks good. Will this be breaking? Will the new entities be numeric and maybe some code uses string and do conversion them self? |
* Draft NumericSensors * Working? * Some cleanup + fix tests * Fix warnings * Improve coverage * Fix small comment and did some more cleanup Co-authored-by: Tomas Hellström <tomas.hellstrom@yahoo.se>
Breaking change
The code generator will now generate NumericSensorEntities for all Sensors that have a 'unit_of_measurement'attribute instead of a normal SensorEntity. InputNumbersEntity is now also derived from NumericEntity
Proposed change
Improved Numeric Entities to also have Numeric values in StateChange Observables. The code generator now also generates some Entities as Numeric
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: