Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash lint/cleanup #640

Merged
merged 4 commits into from
Jan 29, 2022
Merged

Bash lint/cleanup #640

merged 4 commits into from
Jan 29, 2022

Conversation

ludeeus
Copy link
Contributor

@ludeeus ludeeus commented Jan 29, 2022

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2022

Codecov Report

Merging #640 (d6c7ef1) into dev (60a9001) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #640      +/-   ##
==========================================
+ Coverage   80.08%   80.19%   +0.10%     
==========================================
  Files         111      111              
  Lines        2898     2898              
  Branches      311      311              
==========================================
+ Hits         2321     2324       +3     
+ Misses        450      447       -3     
  Partials      127      127              
Flag Coverage Δ
unittests 80.19% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mon.HassClient/Internal/HomeAssistantConnection.cs 85.71% <0.00%> (-0.96%) ⬇️
...sClient/Internal/Net/WebSocketTransportPipeline.cs 91.22% <0.00%> (+0.87%) ⬆️
...mon.HassClient/Internal/Net/WebSocketClientImpl.cs 69.44% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a9001...d6c7ef1. Read the comment docs.

Co-authored-by: Joakim Sørensen <joasoe@gmail.com>
Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cleaned up really well. Thanks alot!

@helto4real helto4real enabled auto-merge (squash) January 29, 2022 11:18
@helto4real helto4real merged commit 8e03d91 into dev Jan 29, 2022
@helto4real helto4real deleted the bash-cleanup branch January 29, 2022 11:27
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
* Bash lint/cleanup

* Update Docker/rootfs/etc/services.d/NetDaemonAdmin/run

Co-authored-by: Joakim Sørensen <joasoe@gmail.com>

Co-authored-by: Tomas Hellström <tomas.hellstrom@yahoo.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants