Testbuild the add-on container #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludeeus
commented
Jan 29, 2022
| @@ -27,6 +32,5 @@ jobs: | |||
| --platform linux/arm,linux/arm64,linux/amd64 \ | |||
| --output "type=image,push=false" \ | |||
| --no-cache \ | |||
| --file ./Dockerfile . \ | |||
| --compress \ | |||
There was a problem hiding this comment.
No need to compress these as they are not published.
There was a problem hiding this comment.
Good point. That only slows down the CI
Codecov Report
@@ Coverage Diff @@
## dev #641 +/- ##
=======================================
Coverage 80.08% 80.08%
=======================================
Files 111 111
Lines 2898 2898
Branches 311 311
=======================================
Hits 2321 2321
Misses 450 450
Partials 127 127
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
helto4real
approved these changes
Jan 29, 2022
| @@ -27,6 +32,5 @@ jobs: | |||
| --platform linux/arm,linux/arm64,linux/amd64 \ | |||
| --output "type=image,push=false" \ | |||
| --no-cache \ | |||
| --file ./Dockerfile . \ | |||
| --compress \ | |||
There was a problem hiding this comment.
Good point. That only slows down the CI
Ikcelaks
pushed a commit
to Ikcelaks/netdaemon
that referenced
this pull request
Dec 23, 2022
Co-authored-by: Tomas Hellström <tomas.hellstrom@yahoo.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: