Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loads HassModel.Integration the proper way #646

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

helto4real
Copy link
Collaborator

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2022

Codecov Report

Merging #646 (d3be62b) into dev (61bcf95) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #646      +/-   ##
==========================================
+ Coverage   80.39%   80.55%   +0.16%     
==========================================
  Files         117      117              
  Lines        3004     3004              
  Branches      321      321              
==========================================
+ Hits         2415     2420       +5     
+ Misses        455      451       -4     
+ Partials      134      133       -1     
Flag Coverage Δ
unittests 80.55% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mon.HassClient/Internal/HomeAssistantConnection.cs 88.57% <0.00%> (+1.90%) ⬆️
...mon.HassClient/Internal/Net/WebSocketClientImpl.cs 69.44% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61bcf95...d3be62b. Read the comment docs.

@helto4real helto4real merged commit 5679308 into dev Jan 31, 2022
@helto4real helto4real deleted the fix-hass-model-integration branch January 31, 2022 06:23
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
* Fixes loading of HassModel.Intergration the proper way.

* Review fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants