Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct names #835

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Correct names #835

merged 1 commit into from
Feb 8, 2023

Conversation

kmgallahan
Copy link
Contributor

@kmgallahan kmgallahan commented Feb 8, 2023 •
edited

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@kmgallahan
Copy link
Contributor Author

Unclear if the PR template needs to be completed for minor changes like this. CONTRIBUTING.md doesn't mention it.

helto4real
helto4real approved these changes Feb 8, 2023
View reviewed changes
Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. All contributions are welcome. Even the small ones :)

@helto4real helto4real enabled auto-merge (squash) February 8, 2023 18:45
@helto4real
Copy link
Collaborator

Unclear if the PR template needs to be completed for minor changes like this. CONTRIBUTING.md doesn't mention it.

Well no, for these kind of PR:s it is sufficient with not fill them out. Especially when they do not even change code .)

@helto4real helto4real merged commit cc21afb into net-daemon:dev Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helto4real helto4real helto4real approved these changes

Assignees
No one assigned
Labels
pr: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kmgallahan @helto4real