Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use doubles instead of integers in the attribute base classes #843

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

helto4real
Copy link
Collaborator

Breaking change

This is technically a breaking change but this feature is still in beta so it should be ok.

Proposed change

Change types of attribute baseclasses from int to double for more roboust serialization. The code generator also use doubles so this makes sense.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@helto4real helto4real changed the title attribute-baseclass-use-doubles Use doubles instead of integers in the attribute base classes Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 80.98% // Head: 81.10% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (5edb470) compared to base (f58c0c7).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #843      +/-   ##
==========================================
+ Coverage   80.98%   81.10%   +0.12%     
==========================================
  Files         159      159              
  Lines        4107     4107              
  Branches      406      406              
==========================================
+ Hits         3326     3331       +5     
+ Misses        620      616       -4     
+ Partials      161      160       -1     
Flag Coverage Δ
unittests 81.10% <0.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mon.HassModel/Entities/Core/LightAttributesBase.cs 0.00% <0.00%> (ø)
...ssModel/Entities/Core/MediaPlayerAttributesBase.cs 0.00% <0.00%> (ø)
...mon.HassClient/Internal/HomeAssistantConnection.cs 88.79% <0.00%> (+1.72%) ⬆️
...mon.HassClient/Internal/Net/WebSocketClientImpl.cs 69.44% <0.00%> (+8.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@phillipsawyer phillipsawyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@helto4real helto4real force-pushed the attribute-baseclass-use-doubles branch from 126253c to 5edb470 Compare February 23, 2023 16:44
@helto4real helto4real merged commit 729f3bd into dev Feb 23, 2023
@helto4real helto4real deleted the attribute-baseclass-use-doubles branch February 23, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants