Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceMetaDataParser bool? Required string deserialization #851

Conversation

pluskal
Copy link
Contributor

@pluskal pluskal commented Mar 5, 2023

Proposed change

Skips invalid sections during deserialization of HassServiceDomain, while logging the exceptions and related source JSON data.

Additionally, allowing deserialization of bool? Required in HassServiceField from string.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Patch coverage: 57.69% and project coverage change: -0.18 ⚠️

Comparison is base (48e0152) 80.98% compared to head (f496897) 80.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #851      +/-   ##
==========================================
- Coverage   80.98%   80.80%   -0.18%     
==========================================
  Files         159      160       +1     
  Lines        4107     4127      +20     
  Branches      406      410       +4     
==========================================
+ Hits         3326     3335       +9     
- Misses        620      629       +9     
- Partials      161      163       +2     
Flag Coverage Δ
unittests 80.80% <57.69%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ator/MetaData/ServicesMetaData/HassServiceField.cs 100.00% <ø> (ø)
...taData/EntityMetaData/NullableBoolJsonConverter.cs 33.33% <33.33%> (ø)
...MetaData/ServicesMetaData/ServiceMetaDataParser.cs 86.27% <70.58%> (-8.73%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@helto4real helto4real merged commit 254c154 into net-daemon:dev Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants