-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent incorrectly initialized Modules to be used #30
Comments
It's not a bug on TweakScale, but it's something that I need to cope. So I'm tagging it as enhancement and "not my fault" ;) |
Fixed on commit bfd7cc8 |
Found a new instance of this problem. Reopening for working on it. |
It was found that by taking a NullReferencePointerException while trying to check for an attribute is also evidence that the Module wasn't correctly initialized by some reason (as a missing It's pretty obvious now that I look behind, but yet, I had missed it. This should explain that somewhat uncomfortable amount of Failed Checks I'm founding on the KSP.logs on the Forum. Fixed (again) on commit: 6467cdc |
In uncertain and beyond TweakScale control, some parts end up with invalid (and unique) TweakScale Module node on the prefab.
This situation has multiple causes, all of them "foreign" to the project. While co-working is possible to minimize the incidence, preemptive detection and prevention is the only safe measure on the long run.
To the moment, the easiest reliable way to detect such misconfigured Nodes is to check if both
tweakScale
andtweakName
fields are set or reset, as exactly one of them must be active in order to TweakScale work correctly - and this setup is done at runtime only.TASK: Implement a Sanity Check on the prefab fase that detects when the above mentioned fields are both set or reset, hinting we have a misconfigured node.
— EDIT —
Failing to check these attributes is also a signal of a incorrectly initialized TweakScale Module.
The text was updated successfully, but these errors were encountered: