Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ERR ***FATAL*** link provided in KSP.log links to 404 #54

Closed
zer0Kerbal opened this issue Jun 13, 2019 · 5 comments
Closed

[ERR ***FATAL*** link provided in KSP.log links to 404 #54

zer0Kerbal opened this issue Jun 13, 2019 · 5 comments
Assignees
Labels
bug Something isn't working My fault I Borked on this one
Milestone

Comments

@zer0Kerbal
Copy link

link created in KSP.log has an additional '.' at the end causing linking to correct URL to fail and hit a 404.

"#34." is what is being linked in npp.

steps:
load KSP and have TweakScale yell about
[WRN 00:06:51.967] [TweakScale] FATAL Found a showstopper problem on [PART].
[ERR 00:06:51.967] [TweakScale] FATAL Part [PART] has a fatal problem due having duplicated properties - see issue #34 - #34.
open log in URL enabled editor/reader after is is flushed to disk.
click on link.
404.

@Lisias
Copy link

Lisias commented Jun 14, 2019

Thanks for the heads up. It's an obvious error, but the thing was working on the release - so I missed that.

Will be fixed in the next minor release.

@Lisias Lisias self-assigned this Jun 14, 2019
@Lisias Lisias added bug Something isn't working My fault I Borked on this one labels Jun 14, 2019
@Lisias Lisias added this to the 2.4.3.1 milestone Jun 14, 2019
@Lisias
Copy link

Lisias commented Jun 14, 2019

Screw this message! I was looking on the wrong code!!!
——

Nope. The code is fine. Something changed somewhere else.

            dlg.Show(
                "Houston, we have a Problem!",
                String.Format(MSG, failure_count),
                () => { Application.OpenURL("https://forum.kerbalspaceprogram.com/index.php?/topic/179030-*"); },
                win, text
            );

@Lisias
Copy link

Lisias commented Jun 14, 2019

Now I understand. It's a typo on the log message. Will be corrected. :)

@zer0Kerbal
Copy link
Author

zer0Kerbal commented Jun 14, 2019

all good. low priority - just trying to help.
And now you know people are clicking the link. :)
I really appreciate this change! (as in the notification).

Lisias added a commit that referenced this issue Jun 17, 2019
@Lisias
Copy link

Lisias commented Jun 17, 2019

Trying mimicking MarkDown styled links - help to emphasis the link and surround them with disallowed chars for URL. Let's see if this stunt sticks. :)

commit: 9632042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working My fault I Borked on this one
Projects
None yet
Development

No branches or pull requests

2 participants