Sanity Check: duplicated properties Support page.

[Lisias]

Due this stunt, properly explained here, a new Sanity Check needs to be implemented.

This stunt essentially shoves Free Scaling in every part on the GameDatabase that has "Cone" in the name!This not only mangles the prefab, but also corrupts craft files and savegames, as they are "tainted" by this misconfiguration  Once you delete the Add'On and Module Manager rebuilds the cache (and the GameDatabase), all your TweakScaled parts gets rescaled terribly wrong!

So, when you load your craft and savegames after installing such Add'On, a lot of parts are wrong (There're more patches like this! The thing is way "greedy" on this). So you "fix" them, and now your parts are incompatible with everybody that doesn't have that Add'On too. And when you uninstall the thing, your crafts and savegames became "corrupted", as the original "type" is back to be effective and Kraken knows what would happen - one of my crafts got the Cones so big that the craft ended up inside an 'egg" - unflyable. And this includes the savegames. Yeah, I need to fix them all on my installment due this.  

It worth to mention that this same stunt when applied on a non visual feature (as resource consumption and mass!) would summon the Sacred Rage of the Krakens on your KSP. This has potential to be very nasty if you don't use the latest TweakScale hat withdraw itself from such parts!

This check should:

• Detect any duplicated properties on each Part's TweakScale module from prefab
• Check against a "whitelist" where (hypothetical) properties that can be duplicated would be ruled out (currently none)
• And then withdraw itself from the Part if non whitelisted properties are duplicated.
  • An error entry should be added to the log file, pinpointing to this issue.

After Math:

Since this have a highly destructive potential, as Stock parts (between others) that used to work suddenly became UnTweakScaled, this has a huge potential to ruining savegames.

The user should be warned and ideally the game must be finished. Whatever it was installed by last, it must be rolled back.

[Lisias]

Implemented on commit eea6046

[Lisias]

Yep. It works… =P

182 Fatals on my main KSP installment. This is going to be interesting...

[Lisias]

Interesting. My old Career instalment (yet on 1.4.3!!) got "only" 12 Fatalities. Way better than the "Company" installment, this one updated to 1.7.0 + MH.

The Career has a bit less Add'Ons than Company, but yet it has a good basket of them.

On a blind guess, this appears to be something that was always there, but only started to bite hard in the last year (from 1.5 ahead, perhaps?)

[Lisias]

The Scale Migration feature implemented in the 2.4.6.x series and described on issue #236 mitigated the problem to a point this is not necessary anymore.

Uncontrolled patching is still a terrible thing, but this is not going to kill the savegame anymore - most of the time, as I can't prevent some idiot from shoving corrupted exponents into parts.

But double patching is not a FATAL anymore, so I'm closing this definitively.

[Tonkyboi1]

Help me with this error, Please?
Line in log: [LOG 21:02:16.060] [TweakScale] ERROR: FATAL Part bdWarheadSmall (Small High Explosive Warhead) has a fatal problem due having duplicated properties - see issue #34. at error:0

[Lisias]

Hi, @Tonkyboi1

Help me with this error, Please?
Line in log: [LOG 21:02:16.060] [TweakScale] ERROR: FATAL Part bdWarheadSmall (Small High Explosive Warhead) has a fatal problem due having duplicated properties - see issue #34. at error:0

Please send me the whole KSP.log, as well the GameData\ModuleManager.ConfigCache and the Log\ModuleManager\MMPatch.log ones (yeah, they are scattered on the file system - I hate this too). I need these files in order to diagnose the source o the problem!

[helpmetweakscale]

KSP.log

[helpmetweakscale]

MMPatch.log

[helpmetweakscale]

https://drive.google.com/file/d/1ZP2dcOXERLEZOc1YYsB2br032YgvY9p4/view?usp=sharing

[Lisias]

KSP.log

Hi, @helpmetweakscale ! Sorry the delay, I'm kinda buried on issues (both here and on Real Life™).

Your problem is due "BladeTweaks". Remove the file `GameData/BladeTweaks/Squad-TweakScale.cfg" and you will be fine.

[343GuiltySpark-04]

i'm getting it for these

https://pastebin.com/1r0GnA84

[343GuiltySpark-04]

which searching the files reveals is stock parts..... well **@#@)

[Lisias]

Hi, @343GuiltySpark-04 !

I need the full KSP.log in order to see who is badly patching these parts. Adding the Logs/ModuleManager/MMPatch.log will help too, as sometimes the KSP.log misses some data related to patching (as when loading from the ModuleManager.ConfigCache.

Cheers!

[TheLocust911]

KSP.log
MMPatch.log

I've got 4 fatal errors related to duplicate properties, help me find root cause? My mods are currently installed via Curse Forge. (on that note it seems like CKAN seemed to do a better job of preventing conflicts lol)

log attached.

[343GuiltySpark-04]

I unfortunately don't have the log but I know it was in the prerelease version 😅 I downloaded it instead by accident.

[Lisias]

@343GuiltySpark-04 ,

I unfortunately don't have the log but I know it was in the prerelease version 😅 I downloaded it instead by accident.

The problem is that without the KSP.log, I can only do blind guess…

Looking on the historical diagnosis, I found this one.

Apparently, you have some oldies lingering around. Completely remove the GameData/TweakScale folder and install TweakScale again. I think this may solve your problem, as the parts affected in your rig are the same from the post I linked above.

[Lisias]

@TheLocust911 ,

I've got 4 fatal errors related to duplicate properties, help me find root cause? My mods are currently installed via Curse Forge. (on that note it seems like CKAN seemed to do a better job of preventing conflicts lol)

You definitively have the same problem I had linked on the previous post. The fix is to completly remove the GameData/TweakScale and install TS again from scratch!

[343GuiltySpark-04]

@343GuiltySpark-04 ,

I unfortunately don't have the log but I know it was in the prerelease version 😅 I downloaded it instead by accident.

The problem is that without the KSP.log, I can only do blind guess…

Looking on the historical diagnosis, I found this one.

Apparently, you have some oldies lingering around. Completely remove the GameData/TweakScale folder and install TweakScale again. I think this may solve your problem, as the parts affected in your rig are the same from the post I linked above.

I'm currently troubleshooting a unrelated issue with my modlist but once that's sorted out I'll try the prerelease version again and pull the log if it happens.

[Lisias]

@343GuiltySpark-04 ,

I'm currently troubleshooting a unrelated issue with my modlist but once that's sorted out I'll try the prerelease version again and pull the log if it happens.

Just to clarify, you don't need to reinstall the pre-release, you can reinstall the current one.

The problem is that it's expected that you completely remove all files from the GameData/TweakScale folder when installing new versions, but since most people don't do it, the Release versions try to handle the mess by adding dummy files to overwrite the older ones that are not needed anymore, preventing old patches from lingering around.

Such precaution is not feasible when installing the Pre-Release (Beta) version, and then installing back the Release (mainstream) one.

By completely removing the TweakScale's folder you have now, and then reinstalling whatever the TweakScale version you wanna run, you will be sure that there will be no lefties lingering around, screwing up the patches.

[343GuiltySpark-04]

I did the crash was when I was running the prerelease version by accident.

[TheLocust911]

Yuppers, worked like a charm

[aussiemilitary]

ive gotten 9 fatal errors, theyre all from stock parts
log: https://drive.google.com/file/d/1nCZ4WDj3Q-tN9yF-D8sQSv9shAAouDyb/view?usp=drive_link

ive already reinstalled tweakscale like 3 times

[Lisias]

Hi, @aussiemilitary !

ive already reinstalled tweakscale like 3 times

Reinstalling TweakScale will never solve these problems, because they are caused by 3rd Parties - so TweakScale is just a messenger for something that it's wrong on your rig.

ive gotten 9 fatal errors, theyre all from stock

Found the problem:

[LOG 18:48:05.071] Applying update LShipParts/LShipPartsRequired/LBP_tweakableComplete/@PART[small*]:NEEDS[TweakScale] to Squad/Parts/Cargo/CargoContainers/smallCargoContainer.cfg/PART[smallCargoContainer]

Unfortunately, not all patches are written the best way, and some had aged pretty badly. This is one of them.

You need to install https://github.com/TweakScale/Companion_SMCE/releases or, even better, https://github.com/TweakScale/Companion/releases (with everything and the kitchen's sink).

Additionally, there's a file on LShipPartsRequired that need to be replaced. You need to copy this file into the GameData/LShipPartsRequired directory, replacing the one that it's there. This is highly irregular, but it's the way I found to fix the problem, as the patches on that replaced file are really, really overeaching parts from everybody else's add'ons (Stock included).

Please note that your LShipPartsRequired is wrongly installed. You need to put this directory directly into GameData, and not inside any other!

Cheers!