Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale RoveMax #6

Closed
Lisias opened this issue Nov 1, 2018 · 6 comments
Closed

Scale RoveMax #6

Lisias opened this issue Nov 1, 2018 · 6 comments
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists good first issue Good for newcomers

Comments

@Lisias
Copy link

Lisias commented Nov 1, 2018

FreeThinker proposed:

One part which could defiantly use a tweakscale fix is the RoveMax Model XL3. The problem is that whenever you try to scale it up, it no longer can properly turn. My first guess is that a tweakscaleconfig should be added for ModuleWheelMotorSteering and scale steeringTorque with exponent 2

source

@Lisias Lisias added bug Something isn't working good first issue Good for newcomers labels Dec 29, 2018
@Lisias Lisias added this to the TweakScale3 milestone Dec 29, 2018
@Lisias
Copy link
Author

Lisias commented Dec 29, 2018

This will be handled on TweakScale3 - aka New Breed.

@Lisias Lisias self-assigned this Mar 7, 2019
@Lisias Lisias modified the milestones: TweakScale3, TweakScale 2.4.1.1 Mar 7, 2019
@Lisias
Copy link
Author

Lisias commented Mar 7, 2019

Changing to be tacked down now, as a minor release is on the works and there's no reason to further delay this one.

@Lisias
Copy link
Author

Lisias commented Mar 7, 2019

I confirmed the problem. The partname is roverWheel3 (Squad/Parts/Wheel/roverWheelXL3)

@Lisias Lisias modified the milestones: TweakScale 2.4.2.0, 2.5.1 May 5, 2019
@Lisias Lisias modified the milestones: 2.5.0.x, 2.4.3.1 Jul 19, 2019
@Lisias
Copy link
Author

Lisias commented Jul 19, 2019

I will tackle down this for 2.4.3.1. I plain forgot this issue, and FreeThinker already hinted about what to do. Inexcusable it took so long to be fixed, sorry guys.

@Lisias
Copy link
Author

Lisias commented Jul 19, 2019

This thing needs a completely overhaul. A new Behaviour need to be build. It's not only ModuleWheelMotorSteering that needs to be scaled, but also the ModuleWheelSuspension .

Some trial and error are on the works, I will tackle this down without a milestone to constrain the R&D.

@Lisias Lisias removed this from the 2.4.3.1 milestone Jul 19, 2019
@Lisias
Copy link
Author

Lisias commented Jul 19, 2019

Things are a bit more troubled than I initially though. On the other hand, are also easier fix - just more work.

I'm closing this as a DUPLICATE for #50 , as it's more sensible to tackle down all the known problems at once.

@Lisias Lisias closed this as completed Jul 19, 2019
@Lisias Lisias added the duplicate This issue or pull request already exists label Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant