Enable MFA with unmatched order of auth_methods #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfazekas
reviewed
Feb 28, 2023
There was a problem hiding this comment.
Thanks much, for the PR, looks great.
We'll need to add an integration test, as well.
Looking at the manpage - AuthenticationMethods can be publickey, publickey
https://man.freebsd.org/cgi/man.cgi?sshd_config(5) it can be 3 elements, and this version of the fix doesn't handle that. What do you think?
| return true if try_authenticate(name, next_service, username, password, key_manager, options) | ||
| end | ||
|
|
||
| # try skipped methods |
There was a problem hiding this comment.
I don't prefer comments, the code is obvious. Or maybe extract to a method like, try_skipped_in_case_allowed_auth_updated, what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #872.
This PR adds tests for MFA, one of them reproduces #872, and updates
Net:SSH:Authetication:Session#authenticateso that new tests pass.