add many algorithm supports #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Key Exchange
* diffie-hellman-group14-sha1
* ecdh-sha2-nistp{256,384,521}
* Host Key
* ecdsa-sha2-nistp{256,384,521}
* Authentication
* ecdsa-sha2-nistp{256,384,521}
* HMAC
* hmac-ripemd160
* Cipher:
* aes{128,192,256}-ctr
* camellia{128,192,256}-ctr
* blowfish-ctr
* cast128-ctr
* 3des-ctr
* arcfour (has problems with weak keys, and should be used with caution)
* camellia{128,192,256}-cbc
|
On a side note, this would make http://net-ssh.lighthouseapp.com/projects/36253/tickets/39-ecdsa-support redundant. |
|
Thank you for the mention. I put a comment on the ticket ( http://net-ssh.lighthouseapp.com/projects/36253/tickets/39-ecdsa-support ) |
|
ping? I've been waiting for comments... |
|
This looks great. I still need to go through it but I'll get it in as soon as I can. Sorry for the delay. |
|
Awesome work. I pulled it into the repo and pushed a 2.5.0 release to Rubygems. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I wrote a patch that implements many algorighms described below.
I've tested with these Rubies on Mac OS X:
(note that Ruby-1.8.6 and JRuby doesn't have OpenSSL::PKey::EC implementation, so "ecdh-" and "ecdsa-" are unavailable under them.)
And I confirmed compatibility with:
Hope it helps.