Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New signature methods #509

Merged
merged 1 commit into from Mar 24, 2017
Merged

New signature methods #509

merged 1 commit into from Mar 24, 2017

Conversation

whiteley
Copy link
Contributor

These were added in openssh/openssh-portable@76c9fbb and available since OpenSSH_7.2p1.

@codecov-io
Copy link

Codecov Report

Merging #509 into master will decrease coverage by 1.2%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
- Coverage   95.57%   94.37%   -1.21%     
==========================================
  Files         142      142              
  Lines        8733     8875     +142     
==========================================
+ Hits         8347     8376      +29     
- Misses        386      499     +113
Impacted Files Coverage Δ
lib/net/ssh/authentication/agent.rb 93.38% <100%> (-5.01%) ⬇️
lib/net/ssh/transport/identity_cipher.rb 83.33% <0%> (-16.67%) ⬇️
lib/net/ssh/verifiers/null.rb 60% <0%> (-15%) ⬇️
lib/net/ssh/test/remote_packet.rb 80% <0%> (-12.31%) ⬇️
lib/net/ssh/verifiers/secure.rb 90.9% <0%> (-9.1%) ⬇️
...t/ssh/transport/kex/diffie_hellman_group14_sha1.rb 92.3% <0%> (-7.7%) ⬇️
lib/net/ssh/authentication/key_manager.rb 83.07% <0%> (-7.61%) ⬇️
lib/net/ssh/test/local_packet.rb 72% <0%> (-6.27%) ⬇️
lib/net/ssh/test/packet.rb 80.95% <0%> (-6.23%) ⬇️
test/authentication/methods/test_hostbased.rb 94.02% <0%> (-5.98%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cba5f9...9abd2c9. Read the comment docs.

@mfazekas
Copy link
Collaborator

Nice, thanks much for the contribution.

Can you show the usecase for this?

@whiteley
Copy link
Contributor Author

@mfazekas my use case is a bit unusual, I want to use ssh-agent to sign API requests for Chef. It can however be used when authenticating to similarly new SSH servers instead of the original SHA1 method.

https://github.com/whiteley/mixlib-authentication/tree/ssh-agent

@mfazekas mfazekas merged commit 078dcbd into net-ssh:master Mar 24, 2017
@whiteley
Copy link
Contributor Author

@mfazekas any ideas on when the next gem release might be scheduled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants