-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failure on musl #381
Comments
Permalink: netaddr/netaddr/tests/strategy/test_ipv6_strategy.py Lines 142 to 148 in 2c89b34
|
This is due to |
Oh yeah it's gonna be 100% that. Short-term I'm happy to accept a PR that makes the test pass conditionally on musl by expecting the other value, although it's not clear to me how one would detect musl. Long-term I think netaddr should make it possible to produce a stable text representation and an implementation-dependent one (which one by default – not sure at this stage). |
What does this return on your machine @TinfoilSubmarine?
|
|
Thank you. One more question, do you mind installing |
|
musl's inet_ntop doesn't format IPv4-compatible IPv6 addresses in any special way and there's no dot notation in the output there. We need to account for that. In doctests this is achieved by changing the examples or, where not applicable, disabling them. In more standard test code we simply made a few tests conditional. Resolves: #381
musl's inet_ntop doesn't format IPv4-compatible IPv6 addresses in any special way and there's no dot notation in the output there. We need to account for that. In doctests this is achieved by changing the examples or, where not applicable, disabling them. In more standard test code we simply made a few tests conditional. Resolves: #381
The fix for this has been released in netaddr 1.3.0. |
Looks similar to https://github.com/netaddr/netaddr/blob/master/netaddr/tests/strategy/test_ipv6_strategy.py#L142-L148
The text was updated successfully, but these errors were encountered: