Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client UI Multiple language support #2192

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

Yxnt
Copy link
Contributor

@Yxnt Yxnt commented Jun 25, 2024

Describe your changes

  1. Add client-side multilingual support(MacOS&Windows)
  2. Automatically adapt multilingualism according to the file mapping rules provided by Windows.

Windows
CleanShot 2024-06-25 at 12 55 38

MacOS
image
image

Issue ticket number and link

#1937

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@bcmmbaga
Copy link
Contributor

Hello @Yxnt,

Thank you for your contribution. This works fine on macOS, but still facing the same issue on Windows. Do I need to install these fonts on Windows for it to work?

image

@Yxnt
Copy link
Contributor Author

Yxnt commented Jun 28, 2024

Hello @Yxnt,

Thank you for your contribution. This works fine on macOS, but still facing the same issue on Windows. Do I need to install these fonts on Windows for it to work?

image

@bcmmbaga It is not necessary to install the font files, Perhaps I may know what the reason is, the way I modified it is to get the default language of the current Windows and call the font file of that language, if it is an English operating system then it does not support Chinese, because the font file of each language of Windows is different.
My modification may be more suitable for users who can't configure other languages, i.e. Chinese users input Chinese, Japanese users input Japanese (not applicable to Chinese users input Japanese/Korean/Thai).

@bcmmbaga bcmmbaga merged commit 4517da8 into netbirdio:main Jul 2, 2024
21 checks passed
lixmal pushed a commit that referenced this pull request Jul 22, 2024
Signed-off-by: Yxnt <jyxnt1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants