Skip to content

Commit

Permalink
build: remove clean dependency from cppcheck targets (#6343)
Browse files Browse the repository at this point in the history
Cleaning does not appear to make a difference; the same amount of files
is checked with/without cleaning.

Environment: cppcheck 2.12.0-3 on Artix Linux.

Added on commit 4e22add ("llvm scan", 2015-11-29).

This is a follow-up to #6222.
  • Loading branch information
kmk3 committed May 20, 2024
1 parent 4e25922 commit 753d199
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -361,13 +361,13 @@ extras: all
$(MAKE) -C extras/firetools

.PHONY: cppcheck
cppcheck: clean
cppcheck:
$(CPPCHECK) --force --error-exitcode=1 --enable=warning,performance \
-i src/firejail/checkcfg.c -i src/firejail/main.c .

# For cppcheck 1.x; see .github/workflows/check-c.yml
.PHONY: cppcheck-old
cppcheck-old: clean
cppcheck-old:
$(CPPCHECK) --force --error-exitcode=1 --enable=warning,performance .

.PHONY: scan-build
Expand Down

0 comments on commit 753d199

Please sign in to comment.