-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiles: claws-mail: add cache support #6378
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
email-common contains private-cache
, so wouldn't these changes be a no-op?
Does the plugin not work with the current profile?
You're absolutely right. This PR makes no sense, my bad. |
I was confused about the plugin not working without the changes, but the It seems good for documentation purposes, to have it blocked in |
Hello, do you want to continue with this PR? It's likely possible to click to restore the branch and then to reopen the PR. |
Hi, I'll take care of it today. Last days of school exams here, less computer-time for me usually. But it shouldn't take that long to restore and reopen this. Thanks for the reminder! |
Ah I see, I wasn't sure if you had seen previous comment, so I commented again Anyway, no hurry on the PR. Good luck on the exams! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the new changes?
It seems like the version from yesterday would work and make it easier to use
the real cache directory if desired.
Oh, I misunderstood. Thought you'd |
I think in general it's good to leave The exceptions would be if the program creates a giant cache (which like Edit: To be clear, I think that the original changes were correct (with the |
Add support for the (widely used)
Fancy plugin
:Renders HTML e-mail using the WebKit library
https://www.claws-mail.org/plugins.php
Related to #6377.