Added environment variable for CSRF_TRUSTED_ORIGINS #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cimnine
reviewed
Apr 8, 2022
cimnine
added
the
enhancement
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #737
New Behavior
Implements the handler for the environment variable "CSRF_TRUSTED_ORIGINS" delimited by space.
...
Contrast to Current Behavior
Netbox introduced the parameter "CSRF_TRUSTED_ORIGINS" as required parameter in configuration.py as Django 4.0 requires the URL Scheme to be set.
The reference configuration.py does not allow setting this value via the ENV File.
The Netbox Issue for this is: netbox-community/netbox#8509 (comment)
This PR adds support in the reference configuration file.
...
Discussion: Benefits and Drawbacks
...
Changes to the Wiki
The wiki needs a reference to this variable on this page.
https://github.com/netbox-community/netbox-docker/wiki/Configuration#configure-for-production
...
Proposed Release Note Entry
Added Envionment Variable CSRF_TRUSTED_ORIGINS to reflect the change that came with Django 4.0
...
Double Check
developbranch.