Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose CSRF_TRUSTED_ORIGINS as a configuration parameter #8509

Closed
jeremystretch opened this issue Feb 1, 2022 · 0 comments
Closed

Expose CSRF_TRUSTED_ORIGINS as a configuration parameter #8509

jeremystretch opened this issue Feb 1, 2022 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@jeremystretch
Copy link
Member

NetBox version

v3.1.6

Feature type

New functionality

Proposed functionality

Expose Django's CSRF_TRUSTED_ORIGINS setting as a parameter that can be defined in configuration.py.

Use case

Currently, this setting is populated with the same hostnames defined in ALLOWED_HOSTS. However, Django 4.0 requires that each entry in CSRF_TRUSTED_ORIGINS now specify a scheme (e.g. http:// or https://) as well. To accommodate this change while also providing a greater degree of flexibility to the user, we can expose CSRF_TRUSTED_ORIGINS directly.

Database changes

No response

External dependencies

No response
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application labels Feb 1, 2022
@jeremystretch jeremystretch self-assigned this Feb 1, 2022
jeremystretch added a commit that referenced this issue Feb 1, 2022
@jeremystretch
Closes #8509: CSRF_TRUSTED_ORIGINS is now a discrete configuration pa…
74c4f12 
…rameter
@ThomasADavis ThomasADavis mentioned this issue Feb 16, 2022
Closed
This was referenced Apr 5, 2022
Closed
Merged
This was referenced Apr 7, 2022
Closed
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeremystretch