Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSO doesn't work for SAML accounts that require idp #10135

Closed
arthanson opened this issue Aug 24, 2022 · 0 comments · Fixed by #10137
Closed

SSO doesn't work for SAML accounts that require idp #10135

arthanson opened this issue Aug 24, 2022 · 0 comments · Fixed by #10137
Assignees
@arthanson
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@arthanson
Copy link
Collaborator

NetBox version

v3.3.0

Python version

3.10

Steps to Reproduce

  1. Setup SAML SSO integration that has idp (see: https://python-social-auth.readthedocs.io/en/latest/backends/saml.html#basic-usage)
  2. Use the SSO signin link on the main NetBox login page

Expected Behavior

The SSO link should work and contain an idp query param

Observed Behavior

The provider will show an error page as the idp isn't given in the QueryParam
@arthanson arthanson added the type: bug A confirmed report of unexpected behavior in the application label Aug 24, 2022
@arthanson arthanson self-assigned this Aug 24, 2022
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Aug 24, 2022
arthanson added a commit to arthanson/netbox that referenced this issue Aug 24, 2022
@arthanson
netbox-community#10135 add idp to saml login
12354ae
arthanson added a commit to arthanson/netbox that referenced this issue Aug 24, 2022
@arthanson
netbox-community#10135 add idp to saml login
741b7f8
arthanson added a commit to arthanson/netbox that referenced this issue Aug 24, 2022
@arthanson
netbox-community#10135 add idp to saml login
d223348
@arthanson arthanson mentioned this issue Aug 24, 2022
Merged
arthanson added a commit to arthanson/netbox that referenced this issue Aug 25, 2022
@arthanson
netbox-community#10135 refactor / cleanup
7fdef17
jeremystretch pushed a commit that referenced this issue Aug 25, 2022
@arthanson
Fix SSO signon for SAML with idp (#10137)
a9ddd41 
* #10135 add idp to saml login

* #10135 add idp to saml login

* #10135 add idp to saml login

* #10135 refactor / cleanup
jeremystretch added a commit that referenced this issue Aug 25, 2022
@jeremystretch
Changelog for #10135
7bdbdda
@jeremystretch jeremystretch mentioned this issue Aug 25, 2022
Merged
arthanson added a commit that referenced this issue Sep 20, 2022
@arthanson
Fix SSO signon for SAML with idp (#10137)
50bd7b9 
* #10135 add idp to saml login

* #10135 add idp to saml login

* #10135 add idp to saml login

* #10135 refactor / cleanup
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arthanson arthanson

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SSO signon for SAML with idp arthanson/netbox
2 participants
@arthanson @jeremystretch