Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Django admin UI #12325

Closed
jeremystretch opened this issue Apr 21, 2023 · 6 comments
Closed

Remove the Django admin UI #12325

jeremystretch opened this issue Apr 21, 2023 · 6 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Milestone

Comments

@jeremystretch
Copy link
Member

jeremystretch commented Apr 21, 2023

Proposed Changes

Disable the Django admin UI entirely. The few functions it still performs currently will be migrated to dedicated views within the primary UI.

Justification

All aspects of NetBox should be accessible via its primary user interface. Disabling the standalone Django admin UI will allow us to deliver a single, cohesive interface, while eliminating dependencies on django.contrib.admin.

Impact

The following admin views will be migrated to the primary UI (some have already been moved):

  • Users
  • Groups
  • Config revisions
  • Permissions
  • Tokens
  • Background tasks
  • Installed plugins

The following admin views will be removed entirely:

  • Views registered by python-social-auth
  • Any admin views registered by plugins
@jeremystretch jeremystretch added status: under review Further discussion is needed to determine this issue's scope and/or implementation type: deprecation Removal of existing functionality or behavior labels Apr 21, 2023
@jeremystretch jeremystretch added this to the v4.0 milestone Apr 21, 2023
@stavr666

This comment was marked as off-topic.

@kkthxbye-code

This comment was marked as off-topic.

@abhi1693
Copy link
Member

abhi1693 commented Jan 5, 2024

It's not a concern but https://github.com/Onemind-Services-LLC/netbox-secrets/ will need to redesign the UIs to allow for this change. Currently, an admin activates the user key from the admin panel and this list of keys is also only visible on the admin side as the UserKey model does not inherit most of the common functionality of NetBox. Atleast for this plugin, apart from moving the UI to tabler it'll basically be a complete UI overhaul along with the core

@jeremystretch
Copy link
Member Author

jeremystretch commented Jan 8, 2024

Blocked by #14728, #14729

@jeremystretch jeremystretch added status: blocked Another issue or external requirement is preventing implementation and removed status: accepted This issue has been accepted for implementation labels Jan 8, 2024
@peteeckel
Copy link
Contributor

No problem here - admin functionality was removed from netbox-plugin-dns a while ago.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: blocked Another issue or external requirement is preventing implementation labels Feb 1, 2024
@jeremystretch jeremystretch self-assigned this Feb 1, 2024
@jeremystretch
Copy link
Member Author

After further discussion, we've decided to stop short of completely eliminating support for the Django admin UI. Instead, we'll disable it by default and provide a configuration parameter to enable it, to support any plugins which still require it.

The admin UI will likely be fully removed in a future release.

jeremystretch added a commit that referenced this issue Feb 5, 2024
* Disable the Django admin UI by default

* Remove outdated references to the admin UI

* Update tests
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Projects
None yet
Development

No branches or pull requests

5 participants