Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Employ the htmx_table template tag to render all HTMX-backed object tables #12776

Closed
jeremystretch opened this issue May 31, 2023 · 0 comments
Closed
Assignees
Labels
status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: housekeeping Changes to the application which do not directly impact the end user
Milestone

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Replace all instances of template code which explicitly embeds an HTMX table with the new htmx_table tag. For instance,

<div class="card-body htmx-container table-responsive"
        hx-get="{% url 'circuits:provideraccount_list' %}?provider_id={{ object.pk }}"
        hx-trigger="load"
      ></div>

becomes

{% htmx_table 'circuits:provideraccount_list' provider_id=object.pk %}

Justification

The htmx_table tag was introduced under #12538 to standardize and simplify our approach for embedding HTMX-backed object tables. Among other benefits, this ensures that the return_url parameter is passed correctly for every embedded table.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels May 31, 2023
@jeremystretch jeremystretch self-assigned this May 31, 2023
@jeremystretch jeremystretch added the topic: UI/UX User interface or user experience related work label Jan 5, 2024
@jeremystretch jeremystretch added this to the v4.0 milestone Jan 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Development

No branches or pull requests

1 participant