Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one device is displayed for multi-termination cables #12951

Closed
pobradovic08 opened this issue Jun 21, 2023 · 3 comments · Fixed by #13030
Closed

Only one device is displayed for multi-termination cables #12951

pobradovic08 opened this issue Jun 21, 2023 · 3 comments · Fixed by #13030
Assignees
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@pobradovic08
Copy link
Contributor

NetBox version

v3.5.4

Python version

3.8

Steps to Reproduce

  1. Create a cable that has multiple one side terminations on different devices
  2. Go to the Cable page
  3. Observe side with multiple terminations (device and interface listed)

Expected Behavior

To display the device and it's interface (tightly coupled together) if there are multiple terminations, like in interface table view:
image
Something like:
image

Observed Behavior

Device is displayed only for first termination:
image

All interfaces are displayed, but it's not clear to which device they belong to.

@pobradovic08 pobradovic08 added the type: bug A confirmed report of unexpected behavior in the application label Jun 21, 2023
@pobradovic08
Copy link
Contributor Author

I have 83fd181 as a quick fix* for this (but didn't want to open a PR yer since it's not assigned to me).

*This is more of an improvement then a fix of the root issue as the same applies to Rack (and maybe even Location and Site), as there is the possibility to have termination in different racks. The current format of Termination data presentation is not optimized for displaying multiple terminations, and might be better to have a table where each row would have all relevant information for each termination.

As the current interface list is really confusing, can we include this partial fix?

@jeremystretch jeremystretch added status: under review Further discussion is needed to determine this issue's scope and/or implementation severity: low Does not significantly disrupt application functionality, or a workaround is available labels Jun 23, 2023
@jeremystretch
Copy link
Member

@pobradovic08 sounds good, assigning this to you.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Jun 27, 2023
@pobradovic08
Copy link
Contributor Author

Thank you @jeremystretch! I had some time to look at this further, and it seems that my concerns from the previous comment can be easily fixed by just chaging a couple of templates.

My proposal would be to have a table with each termination as a row. I would also move A and B sides to be horizontally distributed (instead of one above the other) as that looks better to me, but I would like to hear other's opinion.

Interface (with overall layout):
image

Power feed:
image

Power outlet:
image

Circuits:
image

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants