adding changelog to contact assignments

[opericgithub]

NetBox version

v3.5.4

Feature type

Data model extension

Proposed functionality

currently we cannot see any changes of contact assignments, neither in global changelog, nor in specific contact's changelog tab, nor in objects' (ie. device's) changelog tabs.

we would like to have an evidence of assigning/changing/deassigning contacts to specific objects. this should be visible in global changelog, as well as in 'contact assignments' section, and/or in specific objects' tabs.

it means that we should have new changelog tab in 'contact assignments' section, besides currently existing 'results' and 'filters' tabs. it also means that these changes should be visible in existing global changelog and also in specific changelog tabs.

Use case

we would like to have history of every change of contact assignment, so we could, for exaple, correct the mistake someone made by accidentally deleting contacts from devices.

Database changes

n/a

External dependencies

n/a

[abhi1693]

I checked the global changelog on v3.5.4 and can see all of them.

[opericgithub]

my bad. there is indeed an entry in global changelog.
nevertheless, it might be usefull to also have changelog entries in 'contact assignments' section and maybe also in objects changelog section.

[kkthxbye-code]

Seems that ContactAssignment should have had related_object set on the ObjectChange like we do other places. See examples:

https://github.com/search?q=repo%3Anetbox-community%2Fnetbox%20def%20to_objectchange&type=code

[opericgithub]

Thank you kkthxbye-code for understanding the problem :)

What about adding these changes to the contact's "changelog" tab, and/or to the device's "changelog" tab?

[arthanson]

I'm not sure where the tab would go, the changelog tabs are on specific objects (for example a device detail screen) but contact assignments don't have a detail page, just the list page.

[kkthxbye-code]

@arthanson - Maybe I misunderstood, but I imagined that the related object would be the contact. So when a ContactAssignment is created, it shows up on the Contact changelog.

That looks like this (changelog tab on the Contact after being assigned as contact and unassigned as contact):

Alternatively the related object could be assigned to the ContactAssignment.object, that is the device for example. We can't do both sadly as the related_object field on ObjectChanges only supports one entry. That would have to change if we wanted both ends of the relationship to have the entry.