Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record data source sync errors in the job data #13334

Closed
jeremystretch opened this issue Aug 1, 2023 · 1 comment
Closed

Record data source sync errors in the job data #13334

jeremystretch opened this issue Aug 1, 2023 · 1 comment
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone
v3.7

Comments

@jeremystretch
Copy link
Member

NetBox version

v3.5.7

Feature type

Change to existing functionality

Proposed functionality

When a data source sync job fails, record any relevant error message(s) in the job data. (This is handled by the sync_datasource() function.)

Use case

This will make it easier to troubleshoot issues without shell access. Currently, these errors are being logged but not recorded in the job directly.

Database changes

N/A

External dependencies

N/A
@jeremystretch jeremystretch added type: feature Introduction of new functionality to the application status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Aug 1, 2023
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Oct 13, 2023
@jeremystretch jeremystretch added this to the v3.7 milestone Oct 13, 2023
@jeremystretch jeremystretch self-assigned this Oct 23, 2023
@jeremystretch
Copy link
Member Author

I'm expanding this to cover all background jobs, regardless of specific function.

jeremystretch added a commit that referenced this issue Oct 23, 2023
@jeremystretch
Closes #13334: Record error message on failed jobs
45b4fdd
@jeremystretch jeremystretch mentioned this issue Oct 23, 2023
Merged
jeremystretch added a commit that referenced this issue Oct 31, 2023
@jeremystretch
Closes #13334: Record error message on failed jobs (#14106)
7323668
jeremystretch added a commit that referenced this issue Dec 1, 2023
@jeremystretch
#13334: Capture exception class when recording job error
0c9919a
@jeremystretch jeremystretch mentioned this issue Dec 5, 2023
Closed
@jeremystretch jeremystretch mentioned this issue Dec 29, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
1 participant
@jeremystretch