Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netbox 3.6-beta1 - api tokens - keys now hidden in ui #13439

Closed
ITJamie opened this issue Aug 10, 2023 · 5 comments
Closed

netbox 3.6-beta1 - api tokens - keys now hidden in ui #13439

ITJamie opened this issue Aug 10, 2023 · 5 comments
Assignees
Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation

Comments

@ITJamie
Copy link
Contributor

ITJamie commented Aug 10, 2023

Change Type

Correction

Area

Integrations/API

Proposed Changes

I noticed in the release notes for 3.6-beta1 there is no mention of the fact that API tokens are now partially hidden in the UI for both users under "API Tokens" and in the admin section.

This is a change from past behavior where API keys were viewable, which should probably get called out in the release notes.

@ITJamie ITJamie added the type: documentation A change or addition to the documentation label Aug 10, 2023
@ITJamie ITJamie changed the title netbox 3.6-beta1 - api tokens - key now hidden in ui netbox 3.6-beta1 - api tokens - keys now hidden in ui Aug 10, 2023
@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Aug 10, 2023
@tagur87
Copy link

tagur87 commented Aug 10, 2023

They are also obfuscated in the API: https://beta-demo.netbox.dev/api/users/tokens/

Also appears that you cannot even see the full token when allowing netbox to create the token for you.

@jeremystretch
Copy link
Member

@tagur87 this is not related to any work done in v3.6. The ALLOW_TOKEN_RETRIEVAL configuration parameter was introduced in v3.4.0, and is currently disabled on the demo instance.

@ITJamie
Copy link
Contributor Author

ITJamie commented Aug 10, 2023

apologies, closing out

@ITJamie ITJamie closed this as completed Aug 10, 2023
@jeremystretch
Copy link
Member

API tokens are now partially hidden in the UI for both users under "API Tokens" and in the admin section.

@ITJamie I think you're right to flag this detail. Previously, token keys were always visible in the admin UI. Now that they've been moved to the proper frontend, admins also cannot view token keys when ALLOW_TOKEN_RETRIEVAL is disabled.

@jeremystretch jeremystretch reopened this Aug 10, 2023
@ITJamie
Copy link
Contributor Author

ITJamie commented Aug 10, 2023

No probs ether way. I was comparing against the normal demo instance so i had assumed the config settings would be the same.

Probably good that it wasnt to catch this

@jeremystretch jeremystretch self-assigned this Aug 16, 2023
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Aug 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation
Projects
None yet
Development

No branches or pull requests

3 participants