Adds csv dialect detection to bulk import view #13563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhi1693
requested review from
jeremystretch
and removed request for
jeremystretch
jeremystretch
requested changes
Aug 25, 2023
pv2b
reviewed
Sep 4, 2023
pv2b
reviewed
Sep 4, 2023
abhi1693
commented
Sep 11, 2023
There was a problem hiding this comment.
@jeremystretch Looks good to me with the exception of the slicing because that's dangeours if the auto is moved from the index 0
Good call. I've addressed this by moving the actual delimiting characters to a separate constant, which is wrapped by the choice set (with the addition of the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13239