Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a copy-to-clipboard button to the API token creation form #13962

Closed
jeremystretch opened this issue Oct 3, 2023 · 1 comment · Fixed by #14039
Closed

Add a copy-to-clipboard button to the API token creation form #13962

jeremystretch opened this issue Oct 3, 2023 · 1 comment · Fixed by #14039
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: feature Introduction of new functionality to the application

Comments

@jeremystretch
Copy link
Member

NetBox version

v3.6.3

Feature type

New functionality

Proposed functionality

On the API token creation form, add a button to conveniently copy the randomly-generated API token value to the system clipboard.

API token creation form

Use case

Convenience

Database changes

No response

External dependencies

No response
@jeremystretch jeremystretch added type: feature Introduction of new functionality to the application status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation topic: UI/UX User interface or user experience related work labels Oct 3, 2023
@jsenecal
Copy link
Contributor

jsenecal commented Oct 5, 2023 •
edited
Loading

Isn't that already supported by netbox/templates/account/token.html#L20 and netbox/templates/account/token.html#L32 -> copy_content.html in the detail view of tokens?

If I understand properly, I think the end goal is to prevent the token to be retrieved after saving in the future. In that case we can create a custom form widget with a "copy" button for the key field.

This can be assigned to me if I understand the end goal properly.

@jeremystretch jeremystretch self-assigned this Oct 13, 2023
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Oct 13, 2023
jeremystretch added a commit that referenced this issue Oct 13, 2023
@jeremystretch
Closes #13962: Add a copy-to-clipboard button to the key field of the…
3b80643 
… API token creation form
@jeremystretch jeremystretch mentioned this issue Oct 13, 2023
Merged
jeremystretch added a commit that referenced this issue Oct 17, 2023
@jeremystretch
Closes #13962: Add a copy-to-clipboard button to the key field of the…
51ef4fb 
… API token creation form
jeremystretch added a commit that referenced this issue Oct 17, 2023
@jeremystretch
Changelog for #12336, #13957, #13962, #13972, #14025, #14042
ab9de43
@jeremystretch jeremystretch mentioned this issue Oct 17, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #13962: Add a copy-to-clipboard button for API tokens netbox-community/netbox
2 participants
@jsenecal @jeremystretch