Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move plugins resources from extras to netbox #14036

Closed
jeremystretch opened this issue Oct 13, 2023 · 2 comments · Fixed by #14086
Closed

Move plugins resources from extras to netbox #14036

jeremystretch opened this issue Oct 13, 2023 · 2 comments · Fixed by #14086
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v3.7

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Relocate all plugins resources from the extras app to the netbox app. We can probably arrange to also make these resources available via extras for some time to provide backward compatibility.

Justification

More accurately positions plugins as a central component of NetBox.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Oct 13, 2023
@jeremystretch jeremystretch modified the milestones: v4.0, v3.7 Oct 13, 2023
@tmsagarofficial
Copy link

I would love to work on this issue @jeremystretch .. Pls assign this issue to me so that i can work on this with some guidance here and there 😅

@jeremystretch
Copy link
Member Author

@tmsagarofficial thanks for your interest, however this type of work must be reserved for those who are very familiar with the code base and the implications of every change being made.

@jeremystretch jeremystretch self-assigned this Oct 18, 2023
@jeremystretch jeremystretch mentioned this issue Oct 19, 2023
Merged
jeremystretch added a commit that referenced this issue Oct 20, 2023
@jeremystretch
Closes #14036: Move extras.plugins to netbox.plugins (#14086)
3f40ee5 
* Move extras.plugins to netbox.plugins & add deprecation warnings

* Move plugin template tags from extras to utilities

* Move plugins tests from extras to netbox

* Add TODO reminders for v4.0
jeremystretch added a commit that referenced this issue Dec 29, 2023
@jeremystretch
#14036: Update import paths in example plugin code
c1ff748
This was referenced Dec 29, 2023
Merged
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v3.7
Development

Successfully merging a pull request may close this issue.

Closes #14036: Move extras.plugins to netbox.plugins netbox-community/netbox
2 participants
@jeremystretch @tmsagarofficial