Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mask_length__(lte|gte) filter for IP addresses #14101

Closed
devon-mar opened this issue Oct 22, 2023 · 0 comments · Fixed by #14218
Closed

mask_length__(lte|gte) filter for IP addresses #14101

devon-mar opened this issue Oct 22, 2023 · 0 comments · Fixed by #14218
Assignees
@abhi1693
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@devon-mar
Copy link
Contributor

NetBox version

v3.6.4

Feature type

New functionality

Proposed functionality

The ipam/prefixes API endpoint has the mask_length__gte and mask_length__lte filters while the ipam/ip-addresses endpoint only has mask_length. I propose to add the gte and lte filters to the IP addresses endpoint as well.

I can make a PR for this if accepted.

Use case

I would like to get all point to point interfaces (interfaces with an address with a mask length >= 30 for IPv4 or >= 126 for IPv6).

Database changes

None

External dependencies

None
@devon-mar devon-mar added the type: feature Introduction of new functionality to the application label Oct 22, 2023
@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Nov 6, 2023
@abhi1693 abhi1693 self-assigned this Nov 8, 2023
@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Nov 8, 2023
abhi1693 added a commit that referenced this issue Nov 8, 2023
@abhi1693
adds mask length filters on ipaddress #14101
35f80d0
@abhi1693 abhi1693 mentioned this issue Nov 8, 2023
Merged
jeremystretch added a commit that referenced this issue Nov 9, 2023
@abhi1693 @jeremystretch
Adds mask length filters on ipaddress (#14218)
1203d76 
* adds mask length filters on ipaddress #14101

* Change IPaddress mask_length filter to multi-value; extend tests

---------

Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
jeremystretch added a commit that referenced this issue Nov 9, 2023
@jeremystretch
Changelog for #13669, #13723, #13743, #13951, #14033, #14101, #14112, #…
5000564 
…14113, #14220, #14220
@jeremystretch jeremystretch mentioned this issue Nov 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abhi1693 abhi1693

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds mask length filters on ipaddress netbox-community/netbox
3 participants
@abhi1693 @jeremystretch @devon-mar