Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move & rename extras.webhooks_worker.process_webhook #14395

Closed
jeremystretch opened this issue Nov 30, 2023 · 0 comments
Closed

Move & rename extras.webhooks_worker.process_webhook #14395

jeremystretch opened this issue Nov 30, 2023 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v3.7

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Move the existing process_webhook() function, which is responsible for transmitting queued webhooks, from extras.webhooks_worker to extras.webhooks. I'll also propose renaming it to send_webhook(), which IMO better conveys its function.

We can retain a proxy for this function in its current location to provide backward compatibility until the next release. This will ensure any currently queued webhooks continue to be processed successfully after an upgrade.

Justification

Cleanup in the wake of #14132 and clarification of the function's purpose.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Nov 30, 2023
@jeremystretch jeremystretch added this to the v3.7 milestone Nov 30, 2023
@jeremystretch jeremystretch self-assigned this Nov 30, 2023
jeremystretch added a commit that referenced this issue Dec 1, 2023
@jeremystretch
Closes #14395: Move & rename process_webhook()
a4592db
@jeremystretch jeremystretch mentioned this issue Dec 1, 2023
Merged
jeremystretch added a commit that referenced this issue Dec 1, 2023
@jeremystretch
Closes #14395: Move & rename process_webhook()
85ab7ad
This was referenced Dec 29, 2023
Merged
Closed
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
1 participant
@jeremystretch