Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ENFORCE_GLOBAL_UNIQUE by default #14536

Closed
jeremystretch opened this issue Dec 15, 2023 · 0 comments
Closed

Enable ENFORCE_GLOBAL_UNIQUE by default #14536

jeremystretch opened this issue Dec 15, 2023 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone
v3.7

Comments

@jeremystretch
Copy link
Member

jeremystretch commented Dec 15, 2023 •
edited
Loading

NetBox version

v3.6.6

Feature type

Change to existing functionality

Proposed functionality

Change the default value of the ENFORCE_GLOBAL_UNIQUE configuration parameter from false to true. This will enforce unique IP addressing within the global (non-VRF) table by default.

This change would affect only deployments without any configuration already defined.

Please use a 👍 or 👎 response below to indicate your support for/opposition to this proposed change.

Use case

Enforcing unique IP space by default is more restrictive and thus safer than the current default. Obviously, the parameter can still be toggled as needed.

This change would also be consistent with the enforce_unique field on the VRF model, which defaults to True.

Database changes

No response

External dependencies

No response
@jeremystretch jeremystretch added type: feature Introduction of new functionality to the application status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Dec 15, 2023
@jeremystretch jeremystretch mentioned this issue Dec 15, 2023
Closed
@jeremystretch jeremystretch self-assigned this Dec 19, 2023
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Dec 19, 2023
@jeremystretch jeremystretch added this to the v3.7 milestone Dec 19, 2023
jeremystretch added a commit that referenced this issue Dec 19, 2023
@jeremystretch
Closes #14536: Enable ENFORCE_GLOBAL_UNIQUE by default
2e1e84b
@jeremystretch jeremystretch mentioned this issue Dec 19, 2023
Merged
jeremystretch added a commit that referenced this issue Dec 20, 2023
@jeremystretch
Closes #14536: Enable ENFORCE_GLOBAL_UNIQUE by default
a233dc9
@jeremystretch jeremystretch mentioned this issue Dec 29, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
1 participant
@jeremystretch