Adding host devices to a cluster should exclude devices already assigned

[Gelob]

Issue type

[ ] Feature request
[ X ] Bug report
[ ] Documentation

Environment

• Python version: 2.7.5
• NetBox version: 2.2.1

Description

When searching for devices to add to a virtualization cluster (virtualization/clusters/1/devices/add/), devices that are already part of a cluster show up. If you attempt to add a device that is already part of an existing cluster you will get a Server Error `<type 'exceptions.TypeError'>

'NoneType' object is not iterable`

This would also help in finding devices quicker because the search only returns a limited number of results.

[RyanBreaker]

I'll take a stab at this, hold my beer.

This should also probably be a bug report instead of feature request, especially since it does return an error.

[Gelob]

@RyanBreaker consider your beer held. I've updated it to a bug report. I couldn't decide and figured feature.

[jeremystretch]

@Gelob I'm not able to reproduce this. Could you please update your report with the steps needed to reproduce the error?

[RyanBreaker]

I was actually about to say, I don't get any Python errors but instead just a more generic message saying it cannot be added.

[RyanBreaker]

@jeremystretch I guess it comes down to how we want it to behave then, if we want to just make devices already in a cluster even show up or just disable them from being selectable.

[Gelob]

I think it has to do with when the cluster is assigned to a site, if its not assigned to a site I just get "Select a valid choice. 1812 is not one of the available choices."

If I assign the cluster to a site I do get the attached error

1. Create a new cluster, and assign it to a site.
2. Create a new device in that same site
3. Assign that device to the new cluster you created
4. Try to assign that same device to that cluster (or another cluster that has a site assignment)

[jeremystretch]

Fixed in 34f1a9e