Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System & background tasks menu items should display only for authenticated users #15977

Closed
jeremystretch opened this issue May 6, 2024 · 1 comment · Fixed by #15978
Closed

System & background tasks menu items should display only for authenticated users #15977

jeremystretch opened this issue May 6, 2024 · 1 comment · Fixed by #15978
Assignees
@jeremystretch
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@jeremystretch
Copy link
Member

Deployment Type

NetBox Cloud

NetBox Version

v4.0.0

Python Version

3.11

Steps to Reproduce

  1. Ensure that EXEMPT_VIEW_PERMISSIONS is not set in the configuration and that LOGIN_REQUIRED is false.
  2. Open the NetBox UI as an unauthenticated user.

Expected Behavior

The navigation menu should be empty.

Observed Behavior

Links to the system and background task views are displayed under the "admin" heading in the menu. (Neither link works as both views require authentication.)
@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application status: accepted This issue has been accepted for implementation severity: low Does not significantly disrupt application functionality, or a workaround is available labels May 6, 2024
@jeremystretch jeremystretch self-assigned this May 6, 2024
jeremystretch added a commit that referenced this issue May 6, 2024
@jeremystretch
Fixes #15977: Hide all admin menu items for non-authenticated users
a4789ba
@jeremystretch jeremystretch mentioned this issue May 6, 2024
Merged
jeremystretch added a commit that referenced this issue May 7, 2024
@jeremystretch
Fixes #15977: Hide all admin menu items for non-authenticated users (#…
acc2add 
…15978)

* Fixes #15977: Hide all admin menu items for non-authenticated users

* Account for absence of auth_required on PluginMenuItem
@jeremystretch jeremystretch mentioned this issue May 9, 2024
Merged
@jadyndev
Copy link

The above mentioned menu items are still shown to (authenticated) users without the required permissions to use these menus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremystretch jeremystretch

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #15977: Hide all admin menu items for non-authenticated users netbox-community/netbox
2 participants
@jeremystretch @jadyndev