Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ENABLE_TRANSLATION setting to optionally turn translation off #16096

Merged

Conversation

amyasnikov
Copy link
Contributor

Fixes: #16055

Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this implements the root translation control, it does not address UX: A user can still change his or her language, and would naturally assume that preference to have an effect. Please extend the PR to also disable the user's language preference when translation has been disabled (or at a minimum indicate as much to the user).

netbox/netbox/settings.py Outdated Show resolved Hide resolved
@amyasnikov
Copy link
Contributor Author

amyasnikov commented May 13, 2024

@jeremystretch fixed, pls take a look

badge

@amyasnikov amyasnikov changed the title add USE_I18N setting to optionally turn translation off add ENABLE_TRANSLATION setting to optionally turn translation off May 14, 2024
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amyasnikov!

@jeremystretch jeremystretch merged commit 1feb374 into netbox-community:develop May 14, 2024
3 checks passed
jeremystretch added a commit that referenced this pull request May 14, 2024
@jeremystretch jeremystretch mentioned this pull request May 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to turn translation off
2 participants