Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict all access to authenticated users by default #16107

Closed
jeremystretch opened this issue May 13, 2024 · 0 comments · Fixed by #16122
Closed

Restrict all access to authenticated users by default #16107

jeremystretch opened this issue May 13, 2024 · 0 comments · Fixed by #16122
Assignees
@jeremystretch
Labels
breaking change This change modifies or removes some previously documented functionality status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@jeremystretch
Copy link
Member

jeremystretch commented May 13, 2024 •
edited

NetBox version

v4.0.1

Feature type

Change to existing functionality

Proposed functionality

Currently, the LOGIN_REQUIRED configuration parameter is disabled by default. This issue proposes changing its default value to true (enabled).

Use case

This change will provide a more secure default configuration.

It should be noted that this change will effect a temporarily breaking change for all deployments in which the LOGIN_REQUIRED parameter is not defined, as its default value will change. However, we should expect these to be minimal, as the parameter is included in the example configuration file provided for reference and typically copied at the time of installation.

Database changes

None

External dependencies

None
@jeremystretch jeremystretch added type: feature Introduction of new functionality to the application status: under review Further discussion is needed to determine this issue's scope and/or implementation labels May 13, 2024
@jeremystretch jeremystretch mentioned this issue May 13, 2024
Closed
@jeremystretch jeremystretch added the breaking change This change modifies or removes some previously documented functionality label May 13, 2024
@jeremystretch jeremystretch self-assigned this May 13, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels May 13, 2024
jeremystretch added a commit that referenced this issue May 13, 2024
@jeremystretch
Closes #16107: Set LOGIN_REQUIRED to True by default
79751db
@jeremystretch jeremystretch mentioned this issue May 13, 2024
Merged
jeremystretch added a commit that referenced this issue May 14, 2024
@jeremystretch
Changelog for #16096, #16107, #16123, #16124, #16127
beb9b96
@jeremystretch jeremystretch mentioned this issue May 14, 2024
Merged
@tobiasge tobiasge mentioned this issue May 21, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremystretch jeremystretch

Labels
breaking change This change modifies or removes some previously documented functionality status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #16107: Set LOGIN_REQUIRED to True by default netbox-community/netbox
1 participant
@jeremystretch