Prefix Utilization is Always 0%

[girlpunk]

Issue type

[ ] Feature request
[X] Bug report
[ ] Documentation

Environment

• Python version: 3.5.3
• NetBox version: 2.2.4

Description

Just noticed this after upgrading to the latest version and adding some new prefixes to subnet an existing prefix. After doing so, the utilization for the new prefixes shows the correct number of IPs, but the percentage is always 0%.
This appears to be caused by the get_utilization() function's IPAddress filter.

Steps to reproduce

1. Create a Prefix
2. Add IPs to the prefix
3. Subnet the prefix by adding a child prefix. The prefix correctly identifies the IPs already added, and shows them in the list and utilization count, but not the percentage.

[jeremystretch]

Utilization is counted differently depending on whether the prefix is designated as a container:

    def get_utilization(self):
        """
        Determine the utilization of the prefix and return it as a percentage. For Prefixes with a status of
        "container", calculate utilization based on child prefixes. For all others, count child IP addresses.
        """

Which type of prefix are you looking at?

[girlpunk]

The Utilization on the child prefixes is the one I'm looking at. I've already set the parent to a container, and its utilization is showing correctly. The top child prefix in the screenshot below (192.168.42.0/27) has 10 IPs assigned, so should be showing about 30% usage.

[jeremystretch]

I think I see what's happening. Did you create those ten IPs with a mask larger than /27 (e.g. /24)? If so, the net_contained_or_equal filter won't count them (because a /24 obviously cannot be contained by a /27). Granted, we probably want to see all IPs within a prefix even if their masks are "wrong." I'm going to change the lookup to net_host_contained, which will return all IPs in the given prefix regardless of mask. Hopefully this won't break anything for people; I can't think of a situation where it would.

[girlpunk]

Yes, the IPs were created with /24, because that's the mask in use by the hosts (the subnetting is just for allocation and organisation). That would make sense as to why they're not detected then. Does the count on the prefix page use the net_host_contained function, as that is correct?

[jeremystretch]

@cyberjacob Yes, the count was using net_host_contained but the get_utilization() method on the prefix was using net_contained_or_equal.