Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "Create and assign IP" button to interface creation dialog #2434

Closed
kasimon opened this issue Sep 17, 2018 · 7 comments
Closed

Add a "Create and assign IP" button to interface creation dialog #2434

kasimon opened this issue Sep 17, 2018 · 7 comments
Assignees
@thatmattlove
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone
v3.0

Comments

@kasimon
Copy link

kasimon commented Sep 17, 2018

Environment

  • Python version: 2.7.13
  • NetBox version: 2.4.4

Proposed Functionality

Add another blue "Create and assign IP" button to the interface creation dialog that results in the same view as pressing the green "+" on a interface.

Use Case

Often when adding an interface, users also want to assign an IP address to it. Also the distinction between interface itself and ip addresses configured on the interface (that makes perfectly sense) can be a difficulty to grasp. They have to find the mouseover on the green plus of the created interface to find out how to configure an address to the interface. Having a shortcut directly from the interface creation dialog would result in a much more streamlined experience.

Database Changes

None.

External Dependencies

None.
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Oct 15, 2019
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation type: feature Introduction of new functionality to the application and removed status: accepted This issue has been accepted for implementation type: ui labels Jul 24, 2020
@stale
Copy link

stale bot commented Sep 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our contributing guide.

@stale stale bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Sep 7, 2020
@kasimon
Copy link
Author

kasimon commented Sep 9, 2020

I will try to come up with a patch myself.

@stale stale bot removed the pending closure Requires immediate attention to avoid being closed for inactivity label Sep 9, 2020
@jeremystretch
Copy link
Member

Assigning to @kasimon

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Sep 9, 2020
@jeremystretch
Copy link
Member

@kasimon Are you still working on this?

@kasimon
Copy link
Author

kasimon commented Sep 23, 2020

@jeremystretch I still intend to do so. Haven't had the time for it yet unfortunately.

@jeremystretch
Copy link
Member

@kasimon have you been able to make any progress on this?

@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: accepted This issue has been accepted for implementation labels Mar 29, 2021
@thatmattlove thatmattlove self-assigned this Apr 28, 2021
@thatmattlove thatmattlove added needs milestone Awaiting prioritization for inclusion with a future NetBox release status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation needs milestone Awaiting prioritization for inclusion with a future NetBox release labels Apr 28, 2021
thatmattlove added a commit to thatmattlove/netbox that referenced this issue Apr 30, 2021
@thatmattlove
Closes netbox-community#2434: Added 'Create & Assign IP Address' butt…
3561cec 
…on when adding an interface
@thatmattlove thatmattlove mentioned this issue Apr 30, 2021
Closed
@DanSheps DanSheps added this to the v2.12 milestone Apr 30, 2021
@DanSheps DanSheps linked a pull request Apr 30, 2021 that will close this issue
Closes #2434: Show 'Create & Assign IP Address' Button when Creating Interfaces #6316
Closed
thatmattlove added a commit that referenced this issue Apr 30, 2021
@thatmattlove
Closes #2434: Show 'Create & Assign IP Address' Button when Creating …
00afe58 
…Interfaces
thatmattlove added a commit that referenced this issue Apr 30, 2021
@thatmattlove
Closes #2434: Show 'Create & Assign IP Address' Button when Creating …
de56e2b 
…Interfaces
@thatmattlove thatmattlove mentioned this issue Apr 30, 2021
Merged
thatmattlove added a commit that referenced this issue May 8, 2021
@thatmattlove
#2434: Refactor ComponentCreateView to use generic form validation me…
2d2719c 
…thod

New validate_form method on ComponentCreateView handles validation generically, which any post() method on ComponentCreateView can use to validate the form but handle the response differently as needed.
thatmattlove added a commit that referenced this issue May 8, 2021
@thatmattlove
#2434: Fix redirection logic in generic form validation method
b9a413d
thatmattlove added a commit that referenced this issue May 10, 2021
@thatmattlove
#2434: Apply conditional logic from b9a413d to overridden InterfaceCr…
8056290 
…eateView.post method
thatmattlove added a commit that referenced this issue May 14, 2021
@thatmattlove
#2434: Fix database transaction context scoping
e429ba6
jeremystretch added a commit that referenced this issue May 14, 2021
@jeremystretch
Merge pull request #6323 from netbox-community/feature-2434
fed0322 
Closes #2434: Show 'Create & Assign IP Address' Button when Creating …
jeremystretch added a commit that referenced this issue May 14, 2021
@jeremystretch
Changelog for #2434
dc5c765
@kasimon
Copy link
Author

kasimon commented May 16, 2021 •
edited
Loading

Thanks a lot for implementing this, @checktheroads!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thatmattlove thatmattlove

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

Closes #2434: Show 'Create & Assign IP Address' Button when Creating Interfaces thatmattlove/netbox
4 participants
@kasimon @DanSheps @jeremystretch @thatmattlove